Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change sdg-image-alt text in the lucky-parking.md #3519

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Change sdg-image-alt text in the lucky-parking.md #3519

merged 1 commit into from
Sep 6, 2022

Conversation

plang-psm
Copy link
Member

Fixes #3097

What changes did you make and why did you make them ?

  • change the sdg-image-alt text in the lucky-parking.md file to '11: sustainable cities and communities' from sdg-image-alt: sustainable cities bottom sustainable dev goal

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes were made.

@github-actions
Copy link

github-actions bot commented Sep 5, 2022

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b plang-psm-update-sdg-image-alt-text-3097 gh-pages
git pull https://github.com/plang-psm/website.git update-sdg-image-alt-text-3097

@github-actions github-actions bot added Feature: Accessibility Issues that would broaden website accessibility P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Size: Good second issue labels Sep 5, 2022
@neevliberman neevliberman self-requested a review September 5, 2022 21:08
@neevliberman
Copy link
Member

Review ETA: 3 PM PST, 9-5-22
Availability: 3 Hours

neevliberman
neevliberman previously requested changes Sep 5, 2022
View reviewed changes
Copy link
Member

@neevliberman neevliberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you changed all double quotes to single quotes. Was this for consistency or is there also a functional purpose? Also on line 60 you deleted a whitespace character, I'm also curious about this. Doesn't seem website-breaking but just in case it's good to know why certain changes were made, so it might be helpful to explain in your comment! The change you needed to make was good, otherwise!

_projects/lucky-parking.md Show resolved Hide resolved
@arpitapandya arpitapandya self-requested a review September 6, 2022 02:00
arpitapandya
arpitapandya approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@arpitapandya arpitapandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are correct! Because it doesn't break anything I would approve this. But, I would suggest not to make extra changes for the issues which are about to make line specific change only. Sometimes, that may break other things. Here the issue suggest to make changes to only line 60. Great job @plang-psm

@arpitapandya arpitapandya dismissed neevliberman’s stale review September 6, 2022 02:21

Changes doesn't break so ok to approve for this issue.

@arpitapandya arpitapandya merged commit 50572c2 into hackforla:gh-pages Sep 6, 2022
@plang-psm
Copy link
Member Author

Thank you for catching this! @neevliberman! I only edited line 60 but I believe my editor may have auto formatted once I saved the line with single quotes. I usually use single quotes when coding so thats most likely it. I'll take a look into it to make sure it doesn't happen in the future.

@plang-psm
Copy link
Member Author

Thank you @arpitapandya! I believe the extra changes came from my editor as it may have auto formatted when I saved the file. I'll make sure to change this to prevent any future unwanted changes.

@arpitapandya
Copy link
Member

Thank you @arpitapandya! I believe the extra changes came from my editor as it may have auto formatted when I saved the file. I'll make sure to change this to prevent any future unwanted changes.

@plang-psm Since, the changes has already been merge and updated now, you do not do anything. No problem

@blulady blulady mentioned this pull request Sep 11, 2022
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arpitapandya arpitapandya arpitapandya approved these changes

@neevliberman neevliberman Awaiting requested review from neevliberman

Assignees
No one assigned
Labels
Feature: Accessibility Issues that would broaden website accessibility good first issue Good for newcomers P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change alt text for sdg image in lucky parking md file
4 participants
@plang-psm @neevliberman @arpitapandya @ExperimentsInHonesty